Switch to new mount api for ovl on kernel 6.5 to fix escaping #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the legacy implementation, we want to also add one based on the new mount api. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
overlayfs-argument-escaping
branch
from
21f637c to
7eb4e34
Compare
|
I tested this under strace with 6.5.6-200.fc38.x86_64 (successfully used new api, worked with comma in upperdir), and 6.4.15-200.fc38.x86_64 (falls back to new api both when comma in upperdir and without, both succeeding). |
This is required on kernel >= 6.5 to handle escaped commas in upper or lowerdirs due to an overlayfs change in escape handling behaviour caused by the switch to the new mount api internally. For anything post 6.5 we fallback to the old legacy implementation which supports escaping. See containers#213 for details. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
overlayfs-argument-escaping
branch
from
7eb4e34 to
2995932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required on kernel >= 6.5 to handle escaped commas in upper or lowerdirs due to an overlayfs change in escape handling behaviour caused by the switch to the new mount api internally.
For anything post 6.5 we fallback to the old legacy implementation which supports escaping.
This fixes #213